Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Simpson's rule integration from SBProfile Simpson.h #2

Closed
rmandelb opened this issue Feb 24, 2012 · 2 comments
Closed

Replacing Simpson's rule integration from SBProfile Simpson.h #2

rmandelb opened this issue Feb 24, 2012 · 2 comments
Assignees

Comments

@rmandelb
Copy link
Member

Currently Simpson.h has a NR-based routine for integration by Simpson's rule, which Gary modified so it's written as a template with the integrand as the template argument. We should replace this with some alternative, such as Mike's integration package. Gary points out the decision to be made: whether to adopt the templating interface, or to change sbprofile to do more traditional function calls. The advantage of the template is that the integrand can be a class instead of a function, which allows better control of internal variables.

@ghost ghost assigned rmjarvis Feb 24, 2012
@rmjarvis
Copy link
Member

My integration package also allows the integrand to be a class. I've assigned this to issue to me, since I think it will be pretty trivial for me to adjust the code to use my integrator instead of the current one.

@rmjarvis
Copy link
Member

I finished replacing the occurrences of Simp1d with int1d and I removed Simpson.h, so I'm closing this issue as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants