Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quaxify #140

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat: quaxify #140

merged 4 commits into from
Aug 7, 2024

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Aug 1, 2024

Refactor to be quad-based classes. This enables using jax functions on vectors, e.g. taking vector_norm!
Lot's of followup work to do for other numpy functions.

@nstarman nstarman added this to the v0.8 milestone Aug 1, 2024
@nstarman nstarman force-pushed the feat-quaxify branch 2 times, most recently from 148dbcf to e30a519 Compare August 5, 2024 09:07
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 94.25287% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.09%. Comparing base (bcf9d0a) to head (d13a03e).

Files Patch % Lines
src/coordinax/_base.py 75.00% 2 Missing ⚠️
src/coordinax/_base_acc.py 50.00% 1 Missing ⚠️
src/coordinax/_base_vel.py 50.00% 1 Missing ⚠️
src/coordinax/_space.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   92.88%   93.09%   +0.20%     
==========================================
  Files          67       67              
  Lines        2447     2504      +57     
==========================================
+ Hits         2273     2331      +58     
+ Misses        174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman modified the milestones: v0.8, v0.9 Aug 5, 2024
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman force-pushed the feat-quaxify branch 2 times, most recently from 281b7ae to fa62473 Compare August 7, 2024 08:01
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman marked this pull request as ready for review August 7, 2024 14:15
@nstarman nstarman merged commit fd1f51f into GalacticDynamics:main Aug 7, 2024
14 checks passed
@nstarman nstarman deleted the feat-quaxify branch August 7, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant