Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move PSP to coordinates module #125

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Feb 1, 2024

This PR moves PSP from dynamics to coordinates for 2 reasons:

  1. conceptual: PSP is a coordinate.
  2. submodule dependencies to prevent circular imports. This is especially important with runtime type-checking where we can't use if TYPE_CHECKING blocks the same way as non-runtime-type-checked code. We want the following hierarchy (where higher items can depend on lower items):
    utils -> coordinates -> integrate / potential -> dynamics.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v0.1 milestone Feb 1, 2024
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e1f081) 87.71% compared to head (77e6eab) 87.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   87.71%   87.78%   +0.06%     
==========================================
  Files          42       43       +1     
  Lines        1254     1261       +7     
==========================================
+ Hits         1100     1107       +7     
  Misses        154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman requested a review from adrn February 2, 2024 14:56
@nstarman nstarman merged commit 01d39a9 into GalacticDynamics:main Feb 2, 2024
13 checks passed
@nstarman nstarman deleted the coords-module branch February 2, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant