Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: _potential_energy with Quantity #187

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Mar 5, 2024

Quantities in most places.

@nstarman nstarman added this to the v0.1 milestone Mar 5, 2024
@nstarman nstarman changed the title feat: _potential_energy with Quantity feat: _potential_energy with Quantity Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.46%. Comparing base (c972652) to head (2cf0796).
Report is 73 commits behind head on main.

Files Patch % Lines
src/galax/potential/_potential/base.py 88.88% 6 Missing ⚠️
src/galax/potential/_potential/io/gala.py 0.00% 1 Missing ⚠️
src/galax/potential/_potential/param/field.py 87.50% 1 Missing ⚠️
src/galax/potential/_potential/utils.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   88.44%   89.46%   +1.02%     
==========================================
  Files          42       53      +11     
  Lines        1324     1813     +489     
==========================================
+ Hits         1171     1622     +451     
- Misses        153      191      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman marked this pull request as ready for review March 16, 2024 22:28
@nstarman nstarman merged commit 4fe1e99 into GalacticDynamics:main Mar 16, 2024
13 checks passed
@nstarman nstarman deleted the quantify-pot branch March 16, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant