-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multipole potentials #357
base: main
Are you sure you want to change the base?
Conversation
32646b6
to
c11d4e6
Compare
d6324ca
to
01099dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 94.68% 89.96% -4.72%
==========================================
Files 70 71 +1
Lines 2500 2642 +142
==========================================
+ Hits 2367 2377 +10
- Misses 133 265 +132 ☔ View full report in Codecov by Sentry. |
a9099a3
to
d12d2f1
Compare
gala: gp.MultipolePotential, / | ||
) -> gpx.MultipoleInnerPotential | gpx.MultipoleOuterPotential | gpx.PotentialFrame: | ||
params = gala.parameters | ||
cls = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there's no combined inner/outer multipole expansion in Gala, this wasn't being tested by the automatic testing framework. I'll write a specific test.
@adrn, I think there are more efficient ways to compute this, but this implementation is already quite performant both during and post JIT. I think further efficiencies and code consolidation can happen in a followup PR. |
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
That's a strange one. It was passing. Shouldn't be failing now! |
Multipole potentials. Inner, Outer, & Combined.
This currently does not support time dependence on S/Tlm, but that's entirely because of the__check_init__
.