Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some enhancements to the unit system stuff #45

Merged
merged 12 commits into from
Jan 2, 2024
Merged

Some enhancements to the unit system stuff #45

merged 12 commits into from
Jan 2, 2024

Conversation

adrn
Copy link
Collaborator

@adrn adrn commented Jan 1, 2024

Note: This is built off of #44

This adds some more meat to the UnitSystem port, and adds unit tests.

@nstarman
Copy link
Contributor

nstarman commented Jan 2, 2024 •
edited
Loading

Great! Let's get this in (post merge #44).
Edit: Some merge conflicts.

@adrn
Copy link
Collaborator Author

adrn commented Jan 2, 2024

Cool! I fixed the merge conflict

nstarman
nstarman reviewed Jan 2, 2024
View reviewed changes
noxfile.py Show resolved Hide resolved
nstarman
nstarman reviewed Jan 2, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nstarman
nstarman reviewed Jan 2, 2024
View reviewed changes
src/galax/units.py Outdated Show resolved Hide resolved
nstarman
nstarman approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I had the one comment about running doctests in the CI, but we can tackle that in a future PR.

@adrn
Copy link
Collaborator Author

adrn commented Jan 2, 2024

I had the one comment about running doctests in the CI, but we can tackle that in a future PR.

Sorry I missed that! Done in latest commit.

@nstarman nstarman enabled auto-merge (squash) January 2, 2024 23:44
@nstarman
Copy link
Contributor

nstarman commented Jan 2, 2024

Great! Let's get this in.
@adrn I think your commits are not being signed correctly. The auto-merge is complaining.

@nstarman nstarman disabled auto-merge January 2, 2024 23:45
@nstarman nstarman merged commit bef3275 into GalacticDynamics:main Jan 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstarman nstarman nstarman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrn @nstarman