integrator instance, not class #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstarman
commented
Jan 2, 2024
|
|
||
| integrator = integrator_cls(self._integrator_F, **(integrator_kw or {})) | ||
| ws = integrator.run(qp0, t0, t1, ts) | ||
| ws = integrator_.run(self._integrator_F, qp0, t0, t1, ts) # type: ignore[arg-type] |
There was a problem hiding this comment.
Very strange: _integrator_F is a FCallable. Shouldn't be erroring.
There was a problem hiding this comment.
Where is it erroring? The type checker?
There was a problem hiding this comment.
Yeah, mypy. Had to add the type ignore. Will need to investigate further
nstarman
commented
Jan 2, 2024
|
Ah, yes I think this is a good idea! |
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
|
Fixed. And merging in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing the integrator class and kwargs, you now pass an integrator instance. The integrators are equinox Modules (ie dataclasses) so the state is now reset by calling
replacefor each integration.