MockstreamGenerator returns mockstreams #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not arrays Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not arrays.
This is much closer to
gala, which returns a single Mockstream for the whole stream (versus the 2 returned here).Worth doing incrementally. I have this notion of some
CompositeMockstreamclass that can hold the various pieces of a stream. Gala currently merges the arms into 1 object.With
CompositeMockstreame.g. if we do a sim with an ex-situ then in-situ stream from the same progenitor it would contain 4 Mockstream components.