gala -> galax conversion #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to think about this more, but we might not want to support a public-facing Galax -> Gala conversion. We definitely want to support Gala -> Galax, because people may want to convert their old code to Galax. But given that Galax will be much more flexible in terms of the kinds of parameters you can specify, it might not be worth supporting the inverse! |
|
SGTM. I'll move |
nstarman
force-pushed
the
test-gala
branch
4 times, most recently
from
ac8ab73
to
9e072d3
Compare
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
nstarman
force-pushed
the
test-gala
branch
4 times, most recently
from
f0114c4
to
150ef36
Compare
|
Need to refactor the tests to test this properly. |
Signed-off-by: nstarman <nstarman@users.noreply.github.com> optional dependency Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for UnitSystem and most potentials.
This is the simple and verbose solution.
A fair number of the conversions can be abstracted over when
galax.AbstractPotentialgets a.parametersattribute.But more generally I think this interoperability should be moved to a separate package and registered in using entry points.
I'd also like to add a
to/from_formatdescriptor object togalax.AbstractPotential, like is onastropy.Cosmologyfor a very general convenience layer for object conversion.