Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential parameters attribute #93

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

nstarman
Copy link
Contributor

Modeled after astropy.cosmology. This attribute is computed for each subclass. When called from the class it returns a dict with ParameterField values. When called from an instance it returns a dict with the parameter values.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v0.1 milestone Jan 26, 2024
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman marked this pull request as ready for review January 26, 2024 01:13
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a925ea4) 88.66% compared to head (a903f58) 88.69%.

Files Patch % Lines
src/galax/potential/_potential/param/attr.py 86.36% 3 Missing ⚠️
src/galax/potential/_potential/param/field.py 85.71% 1 Missing ⚠️
src/galax/potential/_potential/param/utils.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   88.66%   88.69%   +0.03%     
==========================================
  Files          35       37       +2     
  Lines        1217     1265      +48     
==========================================
+ Hits         1079     1122      +43     
- Misses        138      143       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman merged commit aaf1d93 into GalacticDynamics:main Jan 26, 2024
13 checks passed
@nstarman nstarman deleted the pot-parameters branch January 26, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant