Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loader #99

Merged
merged 6 commits into from
Jan 27, 2024
Merged

Lazy loader #99

merged 6 commits into from
Jan 27, 2024

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jan 27, 2024

Adopt lazy loading.
Introduces a new dependency, but it is managed by scientific-python. Should decrease package import time.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v0.1 milestone Jan 27, 2024
@nstarman nstarman marked this pull request as ready for review January 27, 2024 23:08
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b11c678) 89.79% compared to head (f7001b5) 86.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   89.79%   86.59%   -3.20%     
==========================================
  Files          37       38       +1     
  Lines        1127     1164      +37     
==========================================
- Hits         1012     1008       -4     
- Misses        115      156      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman merged commit f28fcfe into GalacticDynamics:main Jan 27, 2024
12 of 13 checks passed
@nstarman nstarman deleted the lazy_loader branch January 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant