WIP: grad #4
Closed
WIP: grad #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstarman
commented
Jan 5, 2024
| @@ -732,7 +732,7 @@ def _infeed_p() -> Quantity: | |||
|
|
|||
| @register(lax.integer_pow_p) | |||
| def _integer_pow_p(x: Quantity, *, y: Any) -> Quantity: | |||
There was a problem hiding this comment.
Suggested change
| def _integer_pow_p(x: Quantity, *, y: Any) -> Quantity: | |
| def _integer_pow_p(x: Quantity, *, y: int) -> Quantity: |
nstarman
commented
Jan 5, 2024
| def _mul_p_vq(x: Value, y: Quantity) -> Quantity: | ||
| return Quantity(lax.mul(x, y.value), unit=y.unit) | ||
| def _mul_p_vq(x: DenseArrayValue, y: Quantity) -> Quantity: | ||
| return Quantity(lax.mul(x.array, y.value), unit=y.unit) |
There was a problem hiding this comment.
Check that the .array is necessary. I was getting an infinite loop, but didn't investigate whether this was the best solution.
nstarman
commented
Jan 5, 2024
src/jax_quantity/array_namespace.py
Outdated
There was a problem hiding this comment.
This whole file will hopefully not be necessary if patrick-kidger/quax#5 is resolved successfully.
nstarman
force-pushed
the
grad
branch
5 times, most recently
from
1f37169
to
f89a10d
Compare
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get Quantity working with
jax.grad.