Update config.xml #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rippe's commit (a0e71bd) accidently removes the 1st line which causes compilation to fail with the following error message device/samsung/gt58wifi/overlay/lineage-sdk/lineage/res/res/values/config.xml:0: error: xml parser error: XML or text declaration not at start of entity. The first line should read <?xml version="1.0" encoding="utf-8"?>
|
@retiredtab Hi. Thanks for contribution, but unfortunately we do not accept changes on GitHub, please head to our Gerrit (https://review.msm8916.com) and push a new change there. |
|
I submitted via git commit, but I'm new to all this (github, gerrit, etc) and not sure if it's done right.
If it's not done right, can you please point me to a URL which shows the proper method? Thank you.
|
|
@retiredtab The link I gave you has a documentation page, where you can find how to upload to gerrit. https://review.msm8916.com/Documentation/user-upload.html here it is. |
|
Finally. After 2 hours of trying ...
The instructions you sent helped, but missed one or two points that would have helped me tremendoulsy like where exactly do you cut and paste the ssh key in the web interface (found in settings, ssh keys).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rippe's commit (a0e71bd) accidently removes the 1st line which causes compilation to fail with the following error message
device/samsung/gt58wifi/overlay/lineage-sdk/lineage/res/res/values/config.xml:0: error: xml parser error: XML or text declaration not at start of entity.
The first line should read