Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close mlflow run when a pipeline fails in interactive mode #10

Closed
Galileo-Galilei opened this issue Jun 7, 2020 · 0 comments · Fixed by #52
Closed

Close mlflow run when a pipeline fails in interactive mode #10

Galileo-Galilei opened this issue Jun 7, 2020 · 0 comments · Fixed by #52
Assignees
Labels
bug Something isn't working

Comments

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Jun 7, 2020

Context

Today, you can execute a kedro pipeline interactively. The logic would be to load the context, and then to run the pipeline.

from kedro.context import load_context
local_context = load_context(".")
local_context.run(pipeline=local_context.pipelines[PIPELINE_NAME],
                             catalog=local_context.catalog)

Description

If the execution fails for some reason (bug in the pipeline), the mlflow run is not closed. This creates unintended side effects: for instance, if you rerun the pipeline, the new run will be nested in the failing runs and the mllflow database will become very messy.

This bug does not occur when running from the command line since the mlflow run is automatically closed when exiting.

Possible Implementation

Implement a on_pipeline_error kedro Hook to close the mlflow run when the pipeline fails.

@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Jun 7, 2020
@Galileo-Galilei Galileo-Galilei changed the title Close mlflow run when a pipeline failed Close mlflow run when a pipeline fails in interactive mode Jun 7, 2020
@Galileo-Galilei Galileo-Galilei moved this from Pending to To do in Ongoing development Jun 28, 2020
@Galileo-Galilei Galileo-Galilei self-assigned this Jul 22, 2020
@Galileo-Galilei Galileo-Galilei moved this from To do to In progress in Ongoing development Aug 20, 2020
Galileo-Galilei added a commit that referenced this issue Aug 23, 2020
Galileo-Galilei added a commit that referenced this issue Aug 24, 2020
akruszewski pushed a commit that referenced this issue Aug 25, 2020
@Galileo-Galilei Galileo-Galilei moved this from In progress to Done in Ongoing development Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant