Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mlflow.yml configuration file optional #328

Closed
Galileo-Galilei opened this issue Jun 8, 2022 · 0 comments · Fixed by #340
Closed

Make mlflow.yml configuration file optional #328

Galileo-Galilei opened this issue Jun 8, 2022 · 0 comments · Fixed by #340
Assignees
Labels
enhancement New feature or request

Comments

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Jun 8, 2022

Description

Before using kedro-mlflow in a kedro project, it is needed to create a configuration file with kedro mlflow init command.

Context

It will make plugin installation easier, since it will work "out of the box". Additionnally, I've found that many users don't modify this file, except eventually the mlflow_tracking_uri.

Possible Implementation

Instead of raising error, raise a warnign and instantiate a default KedroMlflowConfig in the after_context_created hook:

try:
conf_mlflow_yml = context.config_loader.get("mlflow*", "mlflow*/**")
except MissingConfigException:
raise KedroMlflowConfigError(
"No 'mlflow.yml' config file found in environment. Use ``kedro mlflow init`` command in CLI to create a default config file."
)

@Galileo-Galilei Galileo-Galilei self-assigned this Jun 18, 2022
@Galileo-Galilei Galileo-Galilei added this to Pending - need design decision in Ongoing development via automation Jun 18, 2022
@Galileo-Galilei Galileo-Galilei added the enhancement New feature or request label Jun 18, 2022
@Galileo-Galilei Galileo-Galilei moved this from Pending - need design decision to Planned for next release in Ongoing development Aug 21, 2022
Ongoing development automation moved this from Planned for next release to Done Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant