Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➖ Drop support for python 3.7 (#391) #434

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Conversation

Galileo-Galilei
Copy link
Owner

Description

Prepare #391

Development notes

What have you changed, and how has this been tested?

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (d0a80d3) 100.00% compared to head (c269c47) 99.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #434      +/-   ##
===========================================
- Coverage   100.00%   99.89%   -0.11%     
===========================================
  Files           28       28              
  Lines          962      982      +20     
===========================================
+ Hits           962      981      +19     
- Misses           0        1       +1     
Impacted Files Coverage Δ
kedro_mlflow/framework/hooks/mlflow_hook.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Galileo-Galilei Galileo-Galilei merged commit 094ec35 into master Jul 23, 2023
12 of 13 checks passed
@Galileo-Galilei Galileo-Galilei deleted the deprecate-python-3.7 branch July 23, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants