Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing DataSet to Dataset#391 #439

Merged
merged 6 commits into from Oct 21, 2023

Conversation

ShubhamZoro
Copy link
Contributor

Description

Changing DataSet to Dataset

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Aug 1, 2023

Hi, thank you very much for this!

Some minor comments but we are almost good to go:

  • you should rebase on because you have a lot of duplicated commits, the git history messed up a little bit
  • you should merge on develop and not master because this is a breaking change. I create the branch right away
  • Can you also change MlflowModelSaverDataSet -> MlflowModelSaverDataset and MlflowModelLoggerDataSet -> MlflowModelLoggerDataset? I am not sure if we will change their names or not, but in case we don't we should change them here.
  • can you mention the change in the CHANGELOG.md?

@Galileo-Galilei
Copy link
Owner

Hi @ShubhamZoro, thank you very much for opening this PR, and once again sorry for not answering fast and give good support to your PR. I'll open another PR to fix the git history, unless you want to give it a try. I'll keep your commits though so you will be credited for the works. Thank you very much for contributing!

@Galileo-Galilei Galileo-Galilei changed the base branch from snyk-fix-2cb949de9c742fd1e4c35a18b93358fc to master October 21, 2023 14:44
@Galileo-Galilei Galileo-Galilei merged commit 57caf45 into Galileo-Galilei:master Oct 21, 2023
0 of 15 checks passed
@Galileo-Galilei Galileo-Galilei mentioned this pull request Oct 21, 2023
12 tasks
@Galileo-Galilei
Copy link
Owner

Thank you for this PR @ShubhamZoro, and sorry for not having been very supportive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants