Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 311 Test #450

Merged
merged 1 commit into from Oct 21, 2023
Merged

Python 311 Test #450

merged 1 commit into from Oct 21, 2023

Conversation

rxm7706
Copy link
Contributor

@rxm7706 rxm7706 commented Sep 4, 2023

Add Python311 to setup
Test Matrix for 3.8 to 3.11
Publish and Pre-release - 3.9 changed to 3.11

Description

Why was this PR created?
Close #449

Development notes

What have you changed, and how has this been tested?

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • [] Update the documentation to reflect the code changes
  • [] Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Test Matrix for 3.8 to 3.11
Publish and Pre-release - 3.9 changed to 3.11

Signed-off-by: rxm7706 <95496360+rxm7706@users.noreply.github.com>
@Galileo-Galilei
Copy link
Owner

Thanks for this! I am pretty sure the tests are failing for things unrelated to python 3.11 but rather to most recent kedro versions. I need to check in details, maybe this weekend.

@Galileo-Galilei
Copy link
Owner

Hi @rxm7706, sorry for the very late reply. It's almost good to go for me (the failing tests do not come from your PR). Can you just add an entry in the changelog? I'll merge it immediately after.

@Galileo-Galilei
Copy link
Owner

Hi @rxm7706, if it's ok for you, I'll take over it!

@rxm7706
Copy link
Contributor Author

rxm7706 commented Oct 18, 2023

@Galileo-Galilei please do !

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review October 21, 2023 14:02
@Galileo-Galilei Galileo-Galilei merged commit 58e19d3 into Galileo-Galilei:master Oct 21, 2023
1 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11 support
2 participants