Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #66 - accessing project context #91

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

takikadiri
Copy link
Collaborator

@takikadiri takikadiri commented Oct 15, 2020

closes #66 #30 #72

Description

This PR intend to fix mlflow configs related issues.

Development notes

Some important changes :

  • kedro-mlflow can now access to project context properties. That decouple the plugin from the template.
    We used this access to change get_mlflow_config signature, the test have been updated accordignately.

  • I add a .kedro.yml file, src folder and run.py file to the kedro project fixture for tests running in kedro 0.16.5

For more details, see changes.

Checklist

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Copy link
Owner

@Galileo-Galilei Galileo-Galilei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great! My comments are really minor and just aim at improving readibility Could you please squash your 2 commits? and create the ingle commit "FIX #66 - Accessing project context inside hooks (and consequently fix #30 #64 #72)"

We're almost good to go!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
kedro_mlflow/framework/hooks/node_hook.py Outdated Show resolved Hide resolved
kedro_mlflow/framework/hooks/pipeline_hook.py Show resolved Hide resolved
kedro_mlflow/framework/hooks/pipeline_hook.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #91 into develop will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #91      +/-   ##
===========================================
+ Coverage    97.33%   97.45%   +0.12%     
===========================================
  Files           32       32              
  Lines         1201     1258      +57     
===========================================
+ Hits          1169     1226      +57     
  Misses          32       32              
Impacted Files Coverage Δ
kedro_mlflow/framework/cli/cli.py 100.00% <100.00%> (ø)
kedro_mlflow/framework/context/mlflow_context.py 100.00% <100.00%> (ø)
kedro_mlflow/framework/hooks/node_hook.py 100.00% <100.00%> (ø)
kedro_mlflow/framework/hooks/pipeline_hook.py 98.78% <100.00%> (+0.06%) ⬆️
tests/conftest.py 100.00% <100.00%> (ø)
tests/framework/context/test_mlflow_context.py 100.00% <100.00%> (ø)
tests/framework/hooks/test_node_hook.py 98.41% <100.00%> (+0.97%) ⬆️
tests/framework/hooks/test_pipeline_hook.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d3bf5...26b6572. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants