Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add keyword arguments to schema's validate() method (#73) #78

Conversation

michal-mmm
Copy link
Contributor

@michal-mmm michal-mmm commented Jul 15, 2024

Description

(#73)

Development notes

What have you changed, and how has this been tested?

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@michal-mmm michal-mmm force-pushed the feature/add-schema-validate-kwargs branch from 8fd083f to bf00a21 Compare July 15, 2024 14:30
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8904511) to head (bf00a21).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          114       116    +2     
=========================================
+ Hits           114       116    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michal-mmm
Copy link
Contributor Author

Hey @Galileo-Galilei, I've made the changes to address the issue in (#73). I've implemented your proposed solution, which works for now. The code could use some additional tests (e.g., testing other arguments of validate method) and refactoring , but I currently don't have enough time to do that.

@Galileo-Galilei
Copy link
Owner

Thank you very much for the PR. I'll have a look by the end of the week, and release a new version to PyPI as soon as it is merged.

@Galileo-Galilei Galileo-Galilei merged commit 24590ec into Galileo-Galilei:main Jul 18, 2024
9 checks passed
Copy link
Owner

@Galileo-Galilei Galileo-Galilei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants