Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Add FOR[JNSQ_Rescale_10x] and FOR[JNSQ_Rescale_1x] #38

Open
Gordon-Dry opened this issue Nov 10, 2021 · 2 comments
Open

Suggestion: Add FOR[JNSQ_Rescale_10x] and FOR[JNSQ_Rescale_1x] #38

Gordon-Dry opened this issue Nov 10, 2021 · 2 comments

Comments

@Gordon-Dry
Copy link
Contributor

So patches for other mods like SMURFF or whatever are able to recognize the different scale by using NEEDS[JNSQ_Rescale_10x] or NEEDS[JNSQ_Rescale_1x]
@Gordon-Dry
Copy link
Contributor Author

I suggest replacing all patches starting with
AFTER[JNSQ]
by

FOR[JNSQ_Rescale_10x]
or
FOR[JNSQ_Rescale_1x]

@Gordon-Dry
Copy link
Contributor Author

Of course the simpler approach is to rename the folder from
JNSQ_Rescale
to

JNSQ_Rescale_10x
or
JNSQ_Rescale_1x

But I guess the folder
PartRebalancer10x\
is kinda SMURFF, isn't it?
That folder could be renamed to
JNSQ_PartRebalancer10x\
though.

@Gordon-Dry Gordon-Dry mentioned this issue Nov 11, 2021
Open
Gordon-Dry added a commit to Gordon-Dry/WhereCanIGo that referenced this issue Nov 11, 2021
@Gordon-Dry
JNSQ_Rescale_10x patches
ebb61ab 
Here is a patch for JNSQ_Rescale_10x which only works if you copy from JNSQ's https://github.com/Galileo88/JNSQ/tree/master/Optional%20Mods/JNSQ_Rescale Rescale_10x into GameData and then rename the folder to JNSQ_Rescale_10x

Also see Galileo88/JNSQ#38
@Gordon-Dry Gordon-Dry mentioned this issue Nov 11, 2021
Merged
Gordon-Dry added a commit to Gordon-Dry/JNSQ that referenced this issue Nov 11, 2021
@Gordon-Dry
rename from JNSQ_Rescale to JNSQ_Rescale_10x
14643b7 
see Galileo88#38
@Gordon-Dry Gordon-Dry mentioned this issue Nov 11, 2021
Open
Gordon-Dry added a commit to Gordon-Dry/JNSQ that referenced this issue Nov 11, 2021
@Gordon-Dry
rename from JNSQ_Rescale to JNSQ_Rescale_1x
36bb52e 
see Galileo88#38
@Gordon-Dry Gordon-Dry mentioned this issue Nov 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gordon-Dry