Fix for vanishing thumbnails, when browser-zoom is active. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in jquery, outerwidth() returns the floor of the actual outerwidth, if the browser is zoom to a value other than 100%. height() returns the floating point value. This caused galleria to compute a wrong width for the 'thumbnails' element. The container was not wide enough and the last thumbnail was displayed in the next line, thus was effectively invisible.
davidhellsing
added a commit
that referenced
this pull request
Oct 11, 2013
Fix for vanishing thumbnails, when browser-zoom is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I discovered the problem that in some cases, the last thumbnail was invisible, when browser-zoom is active. The problem can be observed at [1]. When zooming to 90% the thumbnail disappears (e.g. in Chrome). The fix can be observed at [2]. When doing a lot of zooming, the last thumbnail may still disappear, but it is much more robust, than before the fix.
[1] ]http://www.knappi.org/galleria-error/themes/classic/classic-demo.html
[2] http://www.knappi.org/galleria-fixed/themes/classic/classic-demo.html
Due to a bug in jquery, outerwidth() returns the floor of the
actual outerwidth, if the browser is zoom to a value other than
100%. height() returns the floating point value.
This caused galleria to compute a wrong width for the 'thumbnails'
element. The container was not wide enough and the last thumbnail was
displayed in the next line, thus was effectively invisible.