Image over layer issue on webkit browsers with touch. (Issue #333) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seems to make the images appear above the image layer on wekbit browsers with touch under specific circumstances. For example, take the Galleria Classic theme example for Galleria 1.3.5. Give galleria-layer a background-color. Open Chrome and emulate an iPad 3/4. Open up / refresh the theme example. Slowly drag the image to go to the next one. Expected: You should see the background-color of the galleria-layer on top of the next image as you drag across. Actual Result: The background layer seems to go behind the image. This also seems to happen if you have a small number of images (like 3) and it wraps around from the end to the beginning or vice-versa by clicking the image-nav-left and image-nav-right divs.
|
I didn't realize github creates an issue for pull requests. |
|
Randomly logged in and realized this was still open. I think the problem went away at some point, but I'm not sure how. I think the line I removed was originally added to help gpu accelerated browsers or something. Anyway, I'm closing this as it's probably not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line seems to make the image appear over the image's layer under certain conditions in touch-enabled webkit browsers.
This is my first pull request and first time working with git so if there's anything I need to fix/change, please let me know!