Lightbox fixes, carousel fix, themes cleanup. #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightbox nav holder covered close button. So it needs to have lower z-index.
Fixes issue, that lightbox toggles "iframe" class each image.
When resize (f.ex. enter fullscreen), carousel remained partialy moved, so some thumbnails were hidden.
kuennes
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Looks fine for me for following items:
- lightbox close button not accesible in firefox #318
- lightbox toggles class "iframe" when showing just images #319
- Lightbox pop out requries pressing (X) twice to close (Twelve Theme) #405
Could not verify:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix
lightbox_open event (it triggered on on each image displayed in lightbox)
resolves "lightbox_open" event fires each time, image is loaded #320
lightbox close button (was not accesible)
resolves lightbox close button not accesible in firefox #318 resolves Lightbox pop out requries pressing (X) twice to close (Twelve Theme) #405
lightbox toggles "iframe" class (even if showing only images)
resolves lightbox toggles class "iframe" when showing just images #319
carousel
carousel remained moved on some situations (on resize, /f.ex. enter fullscreen/, when switched to no-carousel), so some images were hidden. this is fixed
themes
some minor typos