fix configMapSelector typo #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes from `configMapSeclector` to `configMapSelector` in the crd.
|
Fixes #153 |
|
Why did you keep the misspelled one? the change to the go-code clearly shows it could never parse it since it was using the right name in go |
|
Both the misspelling and correct spelling works for me. When unmarshalling, the un-marshaller correctly populates the variables from by reading the associated tags ( I didn't fix anything here except a new variable name that preserves the old tag in case it was working a certain way for someone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes from
configMapSeclectortoconfigMapSelectorin the crd.