launcing gdb via pwnlib.tubes.ssh (in a tmux split?) causes an rm of tmpfile locally instead of remotely

[justinsteven]

pwntools/pwnlib/gdb.py

Line 210 in c0f321f

cmd += ['gdb %r %s -x "%s" ; rm "%s"' % (target.exe, target.pid, tmpfile, tmpfile)]

seems to do the rm locally instead of remotely, even though argv seems to be getting set properly. This might be due to the way everything is being wrapped in 'tmux splitw' by run_in_new_terminal()

The following happens to fix the issue:

index 536282f..8b902fa 100644
--- a/pwnlib/gdb.py
+++ b/pwnlib/gdb.py
@@ -207,7 +207,7 @@ def attach(target, execute = None, exe = None, arch = None):
             cmd = ['sshpass', '-p', shell.password] + cmd
         if shell.keyfile:
             cmd += ['-i', shell.keyfile]
-        cmd += ['gdb %r %s -x "%s" ; rm "%s"' % (target.exe, target.pid, tmpfile, tmpfile)]
+        cmd += ['gdb %r %s -x "%s" \\; rm "%s"' % (target.exe, target.pid, tmpfile, tmpfile)]

         misc.run_in_new_terminal(' '.join(cmd))
         return

I'm going to look in to it further, just raising the flag now in case it's biting or will bite someone.