-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix corefile environment variables and speed up ELF.string() #1055
Fix corefile environment variables and speed up ELF.string() #1055
Conversation
a162a75
to
0f4ec4e
Compare
Technically this is present in the I'm still merging this to |
These doctests definitely work locally for me, I'm not sure why they're failing. |
So it looks like the issue is that we're still getting the old corefile.
Note that the exe path is different from what the corefile thinks it should be -- I've fixed this in c491be4 by |
e27647e
to
731fdba
Compare
731fdba
to
ff6881b
Compare
Coverage and Travis pass. Codacy is disabled for |
I'm not sure how the logic for environment variables was supposed to work, but it was broken.
This fixes the environment, and ensures that embedded
=
bytes in the env value (e.g.FOO=BAR=BAZ
) work correctly.A performance enhancement for
ELF.string(...)
which reads a page at a time, rather than a byte at a time.A change to corefile lifecycles such that if
rename_corefiles=True
, the original is deleted. This is to avoid the issue wherecore_pattern=core
and there may be a race condition when two corefiles are created rapidly.Some doctests were added to test these edge cases, including a corrupted stack.