Fix for very old openssl: try sha256 and sha256sum before "openssl sha256" #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sl sha256" doesn't return an error code in some old versions of openssl (OpenSSL 0.9.8g 19 Oct 2007 at least) that doesn't support sha256.
|
It looks like you included some commits you didn’t intend to. Can you fix
your PR? Thanks!
…On Mon, Nov 20, 2017 at 1:24 PM Christophe GRENIER ***@***.***> wrote:
Check for sha256 and sha256sum commands before trying openssl as "openssl
sha256" doesn't return an error code in some old versions of openssl
(OpenSSL 0.9.8g 19 Oct 2007 at least) that doesn't support sha256.
------------------------------
You can view, comment on, or merge this pull request online at:
#1068
Commit Summary
- Fix for overwritten env when parsing core file
- warn_once message when dealing with overwritten pointer to env
variable in core file
- Merge branch 'stable' of https://github.com/Gallopsled/pwntools into
stable
- Check for sha256 and sha256sum before trying openssl sha256 as
"openssl sha256" doesn't return an error code in some old versions of
openssl (OpenSSL 0.9.8g 19 Oct 2007 at least) that doesn't support sha256.
File Changes
- *M* pwnlib/tubes/ssh.py
<https://github.com/Gallopsled/pwntools/pull/1068/files#diff-0> (2)
Patch Links:
- https://github.com/Gallopsled/pwntools/pull/1068.patch
- https://github.com/Gallopsled/pwntools/pull/1068.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1068>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG0GBlqC2S4q85kj4t4fTQC4mslEKmFks5s4eAPgaJpZM4Qk2FZ>
.
|
|
There are some traces from c438893 |
|
LGTM, and I also just ran into this. The other issue is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for sha256 and sha256sum commands before trying openssl as "openssl sha256" doesn't return an error code in some old versions of openssl (OpenSSL 0.9.8g 19 Oct 2007 at least) that doesn't support sha256.