check if ":" exists before index(':') #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cq674350529
reviewed
May 29, 2018
pwnlib/util/proc.py
Outdated
| @@ -245,6 +245,8 @@ def status(pid): | |||
| try: | |||
| with open('/proc/%d/status' % pid) as fd: | |||
| for line in fd: | |||
| if -1 == line.find(':'): | |||
There was a problem hiding this comment.
Maybe this looks better?
if ':' not in line:
continue
There was a problem hiding this comment.
Yeah, this would probably be better. Thanks!
zachriggle
requested changes
May 30, 2018
pwnlib/util/proc.py
Outdated
| @@ -245,6 +245,8 @@ def status(pid): | |||
| try: | |||
| with open('/proc/%d/status' % pid) as fd: | |||
| for line in fd: | |||
| if -1 == line.find(':'): | |||
There was a problem hiding this comment.
Yeah, this would probably be better. Thanks!
zachriggle
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use
gdb.attach(p), I get an error:ValueError: substring not foundI debug it and found that the file /proc/%d/status may have blank line. But util/proc.py doesn't solve it very well. If status file has blank line, then it will raise an error.
So I add some code to detect if ":" exists. If find ":" failed, it will continue.
Sorry for my bad english ...