Fix MIPS PLT on newer Unicorn versions #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently it is us who used unicorn The Wrong Way, e.g. trying to fetch instructions @ 0xdbdbdbdb, which is both unaligned and high-address-space. Unicorn just changed the exception to throw exception with the address of an offending jump instruction, instead of the incorrect address. Making the debugs actually work and changing address to 0x7c7c7c7c solves the issue. Closes Gallopsled#1538 Ping pentoo/pentoo-overlay#734 @blshkv
|
Tested on both py2 and py3 locally, with and without PLT_DEBUG commandline arg set. Merging, since it looks mature and pretty fail-proof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently it is us who used unicorn The Wrong Way,
e.g. trying to fetch instructions @ 0xdbdbdbdb,
which is both unaligned and high-address-space.
Unicorn just changed the exception to throw exception with the address
of an offending jump instruction, instead of the incorrect address.
Making the debugs actually work and changing address to 0x7c7c7c7c
solves the issue.
Closes #1538
Ping pentoo/pentoo-overlay#734 @blshkv