Make ELF symbol dict accept bytes #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we use bytes where possible to avoid mistakes? The function could convert all the strings to bytes internally, and just accept strings as an alternative way of access. |
DynElf symbol lookup uses bytes as key Fixes Gallopsled#1951 Co-authored-by: Arusekk <arek_koz@o2.pl>
Arusekk
changed the title
gogo2464
pushed a commit
to gogo2464/pwntools
that referenced
this pull request
Sep 10, 2023
DynElf symbol lookup uses bytes as key Fixes Gallopsled#1951 Co-authored-by: Arusekk <arek_koz@o2.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pwntools Pull Request
Resolves #1951 DynElf symbol lookup uses string as key for a string-key dictionary now