Force ELF.path to be of type string
#2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks tests for py2. |
|
This won't work in py2 with bytes > b'\x7f'. See context._encode or context._need_bytes etc. |
This commit forces the `path` class variable of the `ELF` class to be of type string, even if a byte string argument is passed. This also makes the implementation consistent with the documentation, which states that `ELF.path` is of type `str`. Fixes Gallopsled#2166 Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
Hmm okay, I have modified the code to use the |
Arusekk
pushed a commit
that referenced
this pull request
May 21, 2023
This commit forces the `path` class variable of the `ELF` class to be of type string, even if a byte string argument is passed. This also makes the implementation consistent with the documentation, which states that `ELF.path` is of type `str`. Fixes #2166 Cherry-picked from 60af3a2 Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
gogo2464
pushed a commit
to gogo2464/pwntools
that referenced
this pull request
Sep 10, 2023
This commit forces the `path` class variable of the `ELF` class to be of type string, even if a byte string argument is passed. This also makes the implementation consistent with the documentation, which states that `ELF.path` is of type `str`. Fixes Gallopsled#2166 Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
gogo2464
pushed a commit
to gogo2464/pwntools
that referenced
this pull request
Sep 10, 2023
This commit forces the `path` class variable of the `ELF` class to be of type string, even if a byte string argument is passed. This also makes the implementation consistent with the documentation, which states that `ELF.path` is of type `str`. Fixes Gallopsled#2166 Cherry-picked from 60af3a2 Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
gogo2464
pushed a commit
to gogo2464/pwntools
that referenced
this pull request
Sep 10, 2023
This commit forces the `path` class variable of the `ELF` class to be of type string, even if a byte string argument is passed. This also makes the implementation consistent with the documentation, which states that `ELF.path` is of type `str`. Fixes Gallopsled#2166 Cherry-picked from 60af3a2 Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2166.
This PR forces the
pathclass variable of theELFclass to be of type string, even if a byte string argument is supplied. This also makes the implementation consistent with the documentation, which states thatELF.pathis of typestr.Signed-off-by: James Raphael Tiovalen jamestiotio@gmail.com