Replace isSet with is_set as the former is deprecated in 3.10+
#2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`threading.Event.isSet` is deprecated here: python/cpython@9825bdf
|
Just making sure: did you try the same in Python 2.x and it still works?
Email z poniedziałku 19 czerwca 2023 od maple:
… `threading.Event.isSet` is deprecated here: python/cpython@9825bdf
So using pwntools with Python 3.10+ will have this warning: `DeprecationWarning: isSet() is deprecated, use is_set() instead`
You can view, comment on, or merge this pull request online at:
#2208
-- Commit Summary --
* Replace `isSet` with `is_set` as the former is deprecated in 3.10+
-- File Changes --
M pwnlib/tubes/tube.py (4)
-- Patch Links --
https://github.com/Gallopsled/pwntools/pull/2208.patch
https://github.com/Gallopsled/pwntools/pull/2208.diff
--
Reply to this email directly or view it on GitHub:
#2208
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
--
Wysłane z mojego urządzenia Sailfish
|
|
No, I didn't try it on Python 2.x, but according to this it should work. |
Arusekk
approved these changes
Jun 19, 2023
gogo2464
pushed a commit
to gogo2464/pwntools
that referenced
this pull request
Sep 10, 2023
…allopsled#2208) `threading.Event.isSet` is deprecated here: python/cpython@9825bdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threading.Event.isSetis deprecated here: python/cpython@9825bdfSo using pwntools with Python 3.10+ will have this warning:
DeprecationWarning: isSet() is deprecated, use is_set() instead