Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellcraft/i386: optimize stackhunter #2231

Merged
merged 4 commits into from Jul 24, 2023
Merged

shellcraft/i386: optimize stackhunter #2231

merged 4 commits into from Jul 24, 2023

Conversation

Arusekk
Copy link
Member

@Arusekk Arusekk commented Jul 17, 2023

Found this opportunity while doing #2230 and could not resist.

@Arusekk Arusekk force-pushed the stackhunter-opt branch 2 times, most recently from e75bce8 to 2c4786b Compare July 17, 2023 12:30
peace-maker
peace-maker approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another byte bites the dust!

The tests are weird since they could save a line by doing with context.local(arch='i386'): directly without assigning to context.arch afterwards, but this isn't directly relevant to this PR.

@Arusekk Arusekk merged commit ac855ab into Gallopsled:dev Jul 24, 2023
9 of 12 checks passed
@Arusekk Arusekk deleted the stackhunter-opt branch July 24, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peace-maker peace-maker peace-maker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arusekk @peace-maker