Publish Docker images through CI #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuild the images on push to the respective branch.
|
Great job! We could probably also make it rebuild the base image on pushes to paths in extra/docker/ if you think it could be useful. |
|
I don't know if you can trigger single steps depending on paths. We could duplicate the action partly with push.paths? |
|
Maybe we could. Does GHA-flavoured YAML support cross-file includes? That would be great for de-duplication. But if not, we can keep it the way you suggest it now. |
|
I don't have time to look into reuseable workflows now, so that improvement can be done later. |
|
@Arusekk Can you allow those actions to be used on this repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild the Docker images on push to the respective branch.
Triggering the workflow manually causes the
baseimage to be rebuild as well as all other images too. So we'll have to trigger this from time to time or when the base image changed.This requires docker hub credentials to be available in the repository secrets
DOCKERHUB_USERNAMEandDOCKERHUB_PASSWORD. The password can be an access token too.Fixes #2187