Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused and broken rop.find_stack_adjustment #2249

Merged
merged 2 commits into from Jul 31, 2023
Merged

Remove unused and broken rop.find_stack_adjustment #2249

merged 2 commits into from Jul 31, 2023

Conversation

fercevik729
Copy link
Contributor

Resolves #2032

@Arusekk
Copy link
Member

Arusekk commented Jul 30, 2023

If the function is not used internally anywhere, maybe it can be removed instead? (not sure what it is useful for)

@peace-maker
Copy link
Member

As you said, if we want to define this as public API, we need to add docs. But then, I don't see when you'd use it too.

@fercevik729
Copy link
Contributor Author

The original issue also didn't provide much context, so I went ahead and removed it for now.

@peace-maker peace-maker changed the title Added missing return to rop.find_stack_adjustment Remove unused and broken rop.find_stack_adjustment Jul 31, 2023
@peace-maker peace-maker merged commit 2e5a33c into Gallopsled:dev Jul 31, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peace-maker peace-maker peace-maker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROP.find_stack_adjustment() is missing a return value
3 participants
@fercevik729 @Arusekk @peace-maker