remove python2 shabangs #2301
Merged
remove python2 shabangs #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tools can be ran directly from the source directory, which is useful during development. So it might be better to just switch them to python3 instead! Although the |
|
I think the files can be made without shebangs, as most of them are not executable anyway; some of them actually are — please make them not executable so we can merge this. |
|
Ah, right. You can just run them through python manually too during development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pwntools Pull Request
In the pwnlib there were handfull of modules being called from the commandlint pwn tools. As these are called from the lib by the pwn executable or wrappers, the executable shabang is not needed.