Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x32 detection was broken since fbf2727
There is special handling in the plt emulation for this, which cannot be reached anymore.
pwntools/pwnlib/elf/plt.py
Lines 80 to 83 in 65f9d57
Setting
context.arch
while loading a x32 ELF caused an exception in theLocalContext.__enter__
function, which caused the context not getting reset while leaving the contextmanager. This causes the behavior seen in #2304, where the log_level is reset to the defaultINFO
and not reset to the old one after leaving the context. (Python context managers not to be confused with pwntools context class)pwntools/pwnlib/elf/elf.py
Lines 278 to 285 in 65f9d57
Fixes #2304