Improved DynELF address resolutions and symbol lookups #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 9, 2024 01:00
Improved _rel_lookup and added Elf64_Rel datatype Added support for _rel_lookup in x86 binaries
+ changelog entry
Bl4ck-C4t
force-pushed
the
dynelf-optimize
branch
from
dc5c11b
to
0f10721
Compare
|
Nice, I'm not too familiar with this code, so proper review will take some time. It's a shame we don't have tests for this yet at all :/ |
|
Yea I could try adding some, but I only tested it on different 64 bit Elfs for now |
Arusekk
approved these changes
Jan 22, 2024
|
Is there anything else needed for this before it is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are centered around not using the leaker function when we can directly read from the ELF object instead (where possible). This especially improves resolving section addresses, even when having an inconsistent leaker function.
Added the Elf64_Rel and Elf32_Rel datatypes (the entries of DT_JMPREL)
Added another way to lookup symbols by using DT_JMPREL when the default way through GNU_HASH fails (as it often does with FULL RELRO binaries).
Also the older
_find_linkmap_assisted(self, path)was removed as it is no longer needed._find_dt(self, tag)will use the elf object to resolve tags, if it can, automatically.This should overall make DynELF more stable, faster and more informative.