Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a lot of documentation #675

Merged
merged 1 commit into from Aug 22, 2016

Conversation

TethysSvensson
Copy link
Contributor

@TethysSvensson TethysSvensson commented Aug 21, 2016

No description provided.

@TethysSvensson
Copy link
Contributor Author

TethysSvensson commented Aug 21, 2016

@zachriggle: I consider this a bugfix. If you disagree, I will do a PR against dev instead.

If you think this is a valid bugfix, reply with ACK, and I will make a new release based upon it.

@TethysSvensson TethysSvensson changed the title Fixed links to readthedocs.org Some stuff related to readthedocs.org Aug 21, 2016
@zachriggle
Copy link
Member

zachriggle commented Aug 22, 2016

docs.pwnies.dk does not resolve, and I don't think has ever been the canonical docs location

@zachriggle
Copy link
Member

zachriggle commented Aug 22, 2016

No need for a new release. This only affects web-facing stuff, and is a no-op in most cases.

@TethysSvensson TethysSvensson force-pushed the readthedocs-fix branch 2 times, most recently from 5b0bc33 to 7126059 Compare Aug 22, 2016
@TethysSvensson TethysSvensson changed the title Some stuff related to readthedocs.org Fix a lot of documentation Aug 22, 2016
@TethysSvensson
Copy link
Contributor Author

TethysSvensson commented Aug 22, 2016

docs.pwnies.dk was a mistake.

After talking to @zachriggle, we agreed that documentation fixes goes into the earliest branch that has the mistake, but they will not trigger new releases.

@zachriggle
Copy link
Member

zachriggle commented Aug 22, 2016

Most of the logic for this is that I expect 99% of documentation use-cases are to view the documentation online, which tracks the branch, not the tag. No need to create a new tag for the documentation to update on-line.

@zachriggle zachriggle merged commit 16de5ec into Gallopsled:stable Aug 22, 2016
@zachriggle zachriggle modified the milestone: 3.2.0 Sep 1, 2016
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants