Refactor command-line tools to use a single "pwn" entry point. #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachriggle
force-pushed
the
pwn-command
branch
from
60cf1e6
to
acf7986
Compare
|
Are you sure we want the default to be to install the aliases? |
|
I didn't want to break backward compatibility and surprise people when
|
|
SGTM. |
Adds an install-time option to disable legacy commands, and only use 'pwn': $ pip install --install-option='--only-use-pwn-command' Documentation is updated to show 'pwn' entry point and sub-commands. Fixes Gallopsled#404 Fixes Gallopsled#660
zachriggle
force-pushed
the
pwn-command
branch
from
acf7986
to
66e41bd
Compare
Kyle-Kyle
pushed a commit
to Kyle-Kyle/pwntools
that referenced
this pull request
Apr 25, 2021
…allopsled#701) * command: support alternatives including sub command wrapper like pwn Additionally speed up the checksec logic by removing the --version check. Simply try to shell out and use the first working option variant as we can't easily detect the different available alternatives in a bulletproof way. This implementation allows to use the sub command wrapper 'pwn' to call checksec in case pwntools has been installed using --only-use-pwn-command To unconditionally unify the usage, the functions cmd attribute stores the base command to execute in form of a list that can be used to concatenate an array of options against it and pass the final list to call_cmd * checksec: allow a third option variant by only passing the file target Lets try a third available version of checksec as the lowest order variant in our cascade that works by only passing the target file without additional specifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an install-time option to disable legacy commands, and only use 'pwn':
$ pip install --install-option='--only-use-pwn-command'
Documentation is updated to show 'pwn' entry point and sub-commands.
Fixes #404
Fixes #660