Add pwnlib.config module and documentation #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachriggle
force-pushed
the
config-file
branch
from
910da53
to
829814b
Compare
|
It's not clear whether we should continue to use |
zachriggle
force-pushed
the
config-file
branch
from
829814b
to
f5e38fc
Compare
TethysSvensson
requested changes
Feb 13, 2017
pwnlib/context/__init__.py
Outdated
| from pwnlib.util import safeeval | ||
| for key, value in section.items(): | ||
| if key not in ContextType.defaults: | ||
| continue |
There was a problem hiding this comment.
Should this get a warning?
pwnlib/log.py
Outdated
| if section not in _msgtype_prefixes: | ||
| def read_log_config(settings): | ||
| for key, value in settings.items(): | ||
| if '.' not in key: |
| elif key == 'symbol': | ||
| _msgtype_prefixes[section][1] = value | ||
| elif key == 'symbol': | ||
| _msgtype_prefixes[msgtype][1] = value |
zachriggle
force-pushed
the
config-file
branch
from
f5e38fc
to
9bc6bcf
Compare
|
Added warning messages, though it requires more circular imports |
This adds functionality for user configuration files at ~/.pwn.conf and /etc/pwn.conf. Previously this was only used by the pwnlib.log module, and was entirely undocumented. This is now documented, and offers an easy mechanism for other parts of the code to have extension points.
zachriggle
force-pushed
the
config-file
branch
from
9bc6bcf
to
857f903
Compare
TethysSvensson
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality for user configuration files at ~/.pwn.conf
and /etc/pwn.conf. Previously this was only used by the pwnlib.log
module, and was entirely undocumented.
This is now documented, and offers an easy mechanism for other parts
of the code to have extension points.
An example configuration might look like: