Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed processing of lists in config file #954

Merged
merged 2 commits into from Apr 18, 2017
Merged

Fixed processing of lists in config file #954

merged 2 commits into from Apr 18, 2017

Conversation

reu-res
Copy link
Contributor

@reu-res reu-res commented Apr 18, 2017

The lists in config file were not processed, for example

[context]
terminal=['tmux', 'splitw', '-h']

@zachriggle
Copy link
Member

Disregard my earlier comments, I just woke up and wasn't looking close enough.

This is a good PR if you change your usage of list and [] to tuple and tuple().

@zachriggle zachriggle self-assigned this Apr 18, 2017
@zachriggle zachriggle added the bug label Apr 18, 2017
@zachriggle zachriggle added this to the Someday milestone Apr 18, 2017
@zachriggle
Copy link
Member

It would be excellent if we could also add tests for this functionality, clearly it's necessary.

@zachriggle zachriggle merged commit e90fb15 into Gallopsled:beta Apr 18, 2017
@reu-res reu-res deleted the fix_config branch April 19, 2017 21:24
@TethysSvensson TethysSvensson modified the milestones: 3.6.0, Someday Apr 19, 2017
@TethysSvensson
Copy link
Contributor

I am not sure of an obvious way to test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zachriggle zachriggle

Labels
bug
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reu-res @zachriggle @TethysSvensson