Fix dd documentation #959
Merged
Fix dd documentation #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbou
force-pushed
the
fix-dd-documentation
branch
2 times, most recently
from
b5e86f7
to
c1b4f79
Compare
micbou
force-pushed
the
fix-dd-documentation
branch
from
c1b4f79
to
c17fec5
Compare
|
I've rewritten the examples to fix the tests. |
|
I'm pretty sure that these being broken indicates that these tests were not actually running. Can you add a test that just does: To check whether these tests are being run? |
|
As you can see in Travis logs, they are run. |
|
Awesome. Mind reverting that commit and re-pushing so that CI passes? Thanks! I wasn't sure that they were being run before since they were clearly broken, but it really does look like they are. |
micbou
force-pushed
the
fix-dd-documentation
branch
from
81ca317
to
c17fec5
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples in the dd documentation are not properly formatted because of missing indentation and null characters not escaped.
Is there something to do to generate the new docs?
This change is