Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining BLS wrapper proofs #70

Merged
merged 109 commits into from
Dec 23, 2021
Merged

Add remaining BLS wrapper proofs #70

merged 109 commits into from
Dec 23, 2021

Conversation

bboston7
Copy link
Contributor

@bboston7 bboston7 commented Dec 22, 2021

This PR adds the remaining BLS wrapper proofs and also cleans up the existing proofs. Specifically, it adds proofs for

  • demo_BasicVerify_B
  • demo_BasicAggregateVerify_A
  • demo_BasicAggregateVerify_B

and moves the existing proofs out of bls_operations.saw and min_key.saw into individual SAW files in proof/bls_operations. It also:

  • Cleans up the existing BLS wrapper proofs
  • Removes some assumptions
  • Proves some assumptions
  • Adds documentation justifying all remaining assumptions introduced for the BLS wrapper proofs

@bboston7
Copy link
Contributor Author

Since I moved all of the BLS proofs around as part of this PR it looks like a bigger change than it is (though it's still a large change). I updated the PR description with a bit more detail about what is new and what proofs were already in master but moved.

Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I appreciate the cleanup work. Thank you @bboston7 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants