Add bytesRead to Data.Serialize.Get #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After another 2 years #8 gets a PR.
I added the current byte count to the state of Get.
Running the benchmark locally, I can't see a major performance hit (only ran each version once though).
I'm a bit unsure about the
MonadPlus
instance and how to add tests. Can you please have a look at those?Also #8 also mentions the idea of a bytesWritten. Looking at the current
Data.Serialize.Put
I don't think it is possible. Was the rewrite already done? Are there plans to go to something similar toData.Serialize.Get
?