Call removeIncludes very early---it is now part of parsing.
#1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to do that, so that we can see included imports, and thus load the correct dependencies for a module. This fixes #1330
yav
changed the title
removeIncludes very early---it is not part of parsing.removeIncludes very early---it is now part of parsing.
RyanGlScott
approved these changes
Mar 2, 2022
Comment on lines
-425
to
-428
| -- remove includes first; we only do this for actual files. | ||
| -- it is less clear what should happen for in-memory things, and since | ||
| -- this is a more-or-less obsolete feature, we are just not doing | ||
| -- ot for now. |
There was a problem hiding this comment.
I think it would be worth migrating this comment to parseModule as well, since it gives the rationale for the InMem case.
src/Cryptol/ModuleSystem/Base.hs
Outdated
| case mb of | ||
| Right ok -> pure ok | ||
| Left err -> noIncludeErrors err | ||
| _ -> pure pm |
There was a problem hiding this comment.
If you migrate the comment, it would be better to match on InMem explicitly here to make the connection more obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to do that, so that we can see included imports, and thus load
the correct dependencies for a module.
This fixes #1330