Support building with mtl-2.3.* (GHC 9.6)
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mtl-2.3.*` no longer re-exports `Control.Monad` from `Control.Monad.Reader`, which breaks some code in `dwarf`. This is easily fixed by tightening up the imports a bit.
kquick
approved these changes
Jun 30, 2023
RyanGlScott
added a commit
to GaloisInc/macaw
that referenced
this pull request
Aug 8, 2023
This patch contains a handful of tweaks needed to make the libraries in the `macaw` repo build with GHC 9.6: * GHC 9.6 bundles `mtl-2.3.*`, which no longer re-exports `Control.Monad`, `Control.Monad.Trans`, and similar modules from `mtl`-related modules. To accommodate this, various imports have been made more explicit. * I have disambiguated a use of `Data.Parameterized.NatRepr.withKnownNat` in `macaw-aarch32` to avoid clashing with a newly exported function of the same name in `GHC.TypeNats`. * I have bumped various upper version bounds on `doctest`, `optparse-applicative`, and `what4` to allow building these libraries with GHC 9.6. * I have bumped the following submodules to bring in GHC 9.6–related changes: * `asl-translator`: GaloisInc/asl-translator#53 * `crucible`: GaloisInc/crucible#1102 * `dwarf`: GaloisInc/dwarf#6 * `elf-edit`: GaloisInc/elf-edit#38 * `flexdis86`: GaloisInc/flexdis86#54 * `grift`: GaloisInc/grift#9 * `llvm-pretty`: GaloisInc/llvm-pretty#112 * `llvm-pretty-bc-parser`: GaloisInc/llvm-pretty-bc-parser#225 * `semmc`: GaloisInc/semmc#80 * `what4`: GaloisInc/what4#235
RyanGlScott
added a commit
to GaloisInc/macaw
that referenced
this pull request
Aug 8, 2023
This patch contains a handful of tweaks needed to make the libraries in the `macaw` repo build with GHC 9.6: * GHC 9.6 bundles `mtl-2.3.*`, which no longer re-exports `Control.Monad`, `Control.Monad.Trans`, and similar modules from `mtl`-related modules. To accommodate this, various imports have been made more explicit. * I have disambiguated a use of `Data.Parameterized.NatRepr.withKnownNat` in `macaw-aarch32` to avoid clashing with a newly exported function of the same name in `GHC.TypeNats`. * I have bumped various upper version bounds on `doctest`, `optparse-applicative`, and `what4` to allow building these libraries with GHC 9.6. * I have bumped the following submodules to bring in GHC 9.6–related changes: * `asl-translator`: GaloisInc/asl-translator#53 * `crucible`: GaloisInc/crucible#1102 * `dwarf`: GaloisInc/dwarf#6 * `elf-edit`: GaloisInc/elf-edit#38 * `flexdis86`: GaloisInc/flexdis86#54 * `grift`: GaloisInc/grift#9 * `llvm-pretty`: GaloisInc/llvm-pretty#112 * `llvm-pretty-bc-parser`: GaloisInc/llvm-pretty-bc-parser#225 * `semmc`: GaloisInc/semmc#80 * `what4`: GaloisInc/what4#235
RyanGlScott
added a commit
to GaloisInc/macaw
that referenced
this pull request
Aug 21, 2023
This patch contains a handful of tweaks needed to make the libraries in the `macaw` repo build with GHC 9.6: * GHC 9.6 bundles `mtl-2.3.*`, which no longer re-exports `Control.Monad`, `Control.Monad.Trans`, and similar modules from `mtl`-related modules. To accommodate this, various imports have been made more explicit. * I have disambiguated a use of `Data.Parameterized.NatRepr.withKnownNat` in `macaw-aarch32` to avoid clashing with a newly exported function of the same name in `GHC.TypeNats`. * I have bumped various upper version bounds on `doctest`, `optparse-applicative`, and `what4` to allow building these libraries with GHC 9.6. * I have bumped the following submodules to bring in GHC 9.6–related changes: * `asl-translator`: GaloisInc/asl-translator#53 * `crucible`: GaloisInc/crucible#1102 * `dwarf`: GaloisInc/dwarf#6 * `elf-edit`: GaloisInc/elf-edit#38 * `flexdis86`: GaloisInc/flexdis86#54 * `grift`: GaloisInc/grift#9 * `llvm-pretty`: GaloisInc/llvm-pretty#112 * `llvm-pretty-bc-parser`: GaloisInc/llvm-pretty-bc-parser#225 * `semmc`: GaloisInc/semmc#80 * `what4`: GaloisInc/what4#235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mtl-2.3.*no longer re-exportsControl.MonadfromControl.Monad.Reader, which breaks some code indwarf. This is easily fixed by tightening up the imports a bit.