Merge pull request #44 from GaloisInc/pate-mctrace

elfSectionAsGOT: improve (and in some cases correct) error messages related to .got section conversion failures
GaloisInc · Mar 20, 2024 · 8afa838 · 8afa838
2 parents 12b6254 + 3401f8f
commit 8afa838
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Data/ElfEdit/HighLevel/GOT.hs b/src/Data/ElfEdit/HighLevel/GOT.hs
@@ -59,16 +59,16 @@ elfSectionAsGOT :: (Bits w, Num w)
 elfSectionAsGOT s = do
   -- TODO: Perform checks
   when (elfSectionType s /= SHT_PROGBITS) $ do
-    Left "Unexpected type"
+    Left "Unexpected .got section type (expected PROGBITS)"
   when (elfSectionFlags s /= elfGotSectionFlags) $ do
-    Left "Unexpected type"
+    Left "Unexpected .got section flags (expected write/alloc)"
   let d = elfSectionData s
   when (elfSectionSize s /= fromIntegral (B.length d)) $ do
-    Left "Section size does not match data length."
+    Left ".got section size does not match data length."
   when (elfSectionLink s /= 0) $ do
-    Left "Unexpected section length"
+    Left "Unexpected .got section length"
   when (elfSectionInfo s /= 0) $ do
-    Left "Unexpected section info"
+    Left "Unexpected .got section info"
   return ElfGOT { elfGotIndex = elfSectionIndex s
                 , elfGotName  = elfSectionName s
                 , elfGotAddr  = elfSectionAddr s