Allow building with GHC 9.8 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch contains a variety of fixes needed to build the libraries in the what4 repo with GHC 9.8: * Bump the upper version bounds on `base` and `text` to allow building with the versions that are bundled with GHC 9.8 (`base-4.19.*` and `text-2.1.*`, respectively). * Replace uses of `head` and `tail` (which trigger `-Wx-partial` warnings with GHC 9.8) with total functions or `panic`s, depending on what is appropriate. * Bump the `aig` submodule to bring in the changes from GaloisInc/aig#16 and GaloisInc/aig#17.
The previous code, defined in terms of `unsnoc`, required multiple `panic` cases, which was somewhat unsightly. This new implementation is functionally equivalent, does not require any `panic` fall-through cases, and is much nicer to look at.
kquick
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch contains a variety of fixes needed to build the libraries in the
what4repo with GHC 9.8:baseandtextto allow building with the versions that are bundled with GHC 9.8 (base-4.19.*andtext-2.1.*, respectively).headandtail(which trigger-Wx-partialwarnings with GHC 9.8) with total functions orpanics, depending on what is appropriate.aigsubmodule to bring in the changes from Allow building withbase-4.19.*(GHC 9.8) aig#16 and Allow building withtasty-1.5.*aig#17.